Skip to content

Support Showing Search Window at Topmost #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Support Showing Search Window at Topmost #3541

wants to merge 6 commits into from
+49 −8

Conversation

Jack251970
Copy link
Contributor

@Jack251970 Jack251970 commented May 13, 2025 •
edited
Loading

Support Showing Search Window At Topmost

Use this option to show window above other windows. Inspired by Fluent Search.

image

Test

  • On/Off the option can set window Topmost state.
2025-05-14.11-52-16.mp4

@Jack251970 Jack251970 requested review from Copilot and onesounds May 13, 2025 14:07
@Jack251970 Jack251970 enabled auto-merge May 13, 2025 14:07
Copilot
Copilot AI reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for showing the search window at topmost by introducing a new user setting. Key changes include adding a new toggle in the general settings UI, updating the main window to apply the topmost property based on the setting, and adding the corresponding localization strings and settings property.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml Adds a new Card with a ToggleSwitch for the topmost setting.
Flow.Launcher/MainWindow.xaml.cs Sets the window’s Topmost property on initialization and upon settings changes.
Flow.Launcher/Languages/en.xaml Introduces new localization keys for the topmost setting.
Flow.Launcher.Infrastructure/UserSettings/Settings.cs Implements the new ShowAtTopmost property with proper change notification.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Jack251970 Jack251970 added the enhancement New feature or request label May 13, 2025
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented May 13, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 13, 2025 •
edited
Loading

📝 Walkthrough

"""

Walkthrough

A new "Show Search Window at Topmost" feature is introduced, allowing users to keep the search window above other windows. This includes updates to settings logic, UI, resource strings, and runtime behavior to support toggling the window's "Topmost" property based on user preference.

Changes

File(s) Change Summary
Flow.Launcher.Infrastructure/UserSettings/Settings.cs Added ShowAtTopmost property with change notification; optimized setters of several existing properties.
Flow.Launcher/Languages/en.xaml Added two string resources: showAtTopmost and showAtTopmostToolTip for UI text and tooltip.
Flow.Launcher/MainWindow.xaml.cs Integrated ShowAtTopmost setting: initializes and updates window's Topmost property based on setting value.
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml Added a toggle switch card to the general settings pane for the new "Show at Topmost" feature.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsPaneGeneral (UI)
    participant Settings
    participant MainWindow

    User->>SettingsPaneGeneral (UI): Toggles "Show at Topmost"
    SettingsPaneGeneral (UI)->>Settings: Updates ShowAtTopmost property
    Settings-->>MainWindow: PropertyChanged event (ShowAtTopmost)
    MainWindow->>MainWindow: Updates Topmost property
Loading

Possibly related PRs

Suggested labels

kind/ui

Suggested reviewers

  • onesounds

Poem

A toggle appears, a window ascends,
"Stay on top!" the user intends.
With settings refined and a string or two,
The search floats above, in a sky so blue.
🐇✨
Code hops along, windows obey—
Topmost dreams are here to stay!
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b636f25 and 9e85d2e.

📒 Files selected for processing (2)
  • Flow.Launcher.Infrastructure/UserSettings/Settings.cs (3 hunks)
  • Flow.Launcher/MainWindow.xaml.cs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • Flow.Launcher/MainWindow.xaml.cs
  • Flow.Launcher.Infrastructure/UserSettings/Settings.cs
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Report (PR)
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 changed the title Support Showing Search Window At Topmost Support Showing Search Window at Topmost May 13, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@jjw24
Copy link
Member

jjw24 commented May 13, 2025

What's the difference between this and setting hide when lost focus to off?

@Jack251970
Copy link
Contributor Author

Jack251970 commented May 14, 2025 •
edited
Loading

What's the difference between this and setting hide when lost focus to off?

Setting Hide when lost focus off and this on will make this window always on top above all other windows. After showing the search window, it will pin to the top. When you open other windows, they will put under the search window. (related to z-order of windows)

@Jack251970
Copy link
Contributor Author

@jjw24 Here is the demo video.

2025-05-14.11-52-16.mp4

@jjw24 jjw24 added this to the Future milestone May 14, 2025
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented May 14, 2025

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Activity based on git-commit:

Jack251970 onesounds
MAY 28 additions & 6 deletions
APR 34 additions & 83 deletions 104 additions & 38 deletions
MAR 142 additions & 94 deletions 10 additions & 0 deletions
FEB 10 additions & 4 deletions
JAN 17 additions & 4 deletions
DEC 1 additions & 1 deletions

Knowledge based on git-blame:
Jack251970: 24%
onesounds: 21%

Flow.Launcher/Languages/en.xaml

Activity based on git-commit:

Jack251970 onesounds
MAY 11 additions & 0 deletions
APR 22 additions & 21 deletions 45 additions & 23 deletions
MAR 67 additions & 42 deletions 8 additions & 3 deletions
FEB 15 additions & 9 deletions
JAN 1 additions & 0 deletions
DEC

Knowledge based on git-blame:
onesounds: 42%
Jack251970: 11%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

Jack251970 onesounds
MAY 130 additions & 33 deletions 5 additions & 1 deletions
APR 69 additions & 45 deletions 5 additions & 1 deletions
MAR 1141 additions & 1076 deletions 327 additions & 141 deletions
FEB 1 additions & 1 deletions 8 additions & 4 deletions
JAN
DEC 5 additions & 10 deletions

Knowledge based on git-blame:
Jack251970: 68%
onesounds: 14%

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

Jack251970 onesounds
MAY 40 additions & 11 deletions
APR 11 additions & 8 deletions 130 additions & 69 deletions
MAR 44 additions & 20 deletions 43 additions & 62 deletions
FEB 1 additions & 1 deletions
JAN 8 additions & 1 deletions
DEC

Knowledge based on git-blame:
onesounds: 62%
Jack251970: 13%

To learn more about /:\ gitStream - Visit our Docs

@github-actions GitHub Actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 24
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@onesounds onesounds Awaiting requested review from onesounds

At least 1 approving review is required to merge this pull request.

Assignees

@Jack251970 Jack251970

Labels
5 min review enhancement New feature or request
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
2 participants
@Jack251970 @jjw24